Add ContainerStatistics proto messages for Stats shim query#695
Closed
jterry75 wants to merge 1 commit intomicrosoft:masterfrom
Closed
Add ContainerStatistics proto messages for Stats shim query#695jterry75 wants to merge 1 commit intomicrosoft:masterfrom
jterry75 wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@kevpar - This is just the proto part but should unblock you |
jterry75
commented
Sep 17, 2019
Random-Liu
reviewed
Sep 18, 2019
jterry75
force-pushed
the
container_stats
branch
2 times, most recently
from
37451eb to
b723892
Compare
jterry75
commented
Sep 18, 2019
jterry75
force-pushed
the
container_stats
branch
from
b723892 to
364f14b
Compare
jterry75
changed the title
jterry75
force-pushed
the
container_stats
branch
2 times, most recently
from
66e11a7 to
edf78f8
Compare
jterry75
changed the title
Contributor
Author
|
@katiewasnothere, @kevpar - This is close. We need to implement the method in the OpenGCS for LCOW to match the host expectation in hcs_task.go but I believe this should be 90% there. @katiewasnothere - Please take the commit test/improve and feel free to carry onto a new PR or push a new commit here if needed. Thanks |
Implements WCOW/LCOW V2 container statistics queries on the shim stats calls. Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
jterry75
force-pushed
the
container_stats
branch
from
edf78f8 to
480159a
Compare
Contributor
Author
|
@katiewasnothere - Ok that should fix the build break in the test code. |
Contributor
Author
|
@katiewasnothere - Do we want to take this PR and then you submit your changes or do we want to close it out? |
Contributor
Author
|
Closing in favor of #719. @Random-Liu - Should be good to revendor into upstream now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements WCOW/LCOW V2 container statistics queries on the shim stats calls.
Signed-off-by: Justin Terry (VM) juterry@microsoft.com