fix: remove extra argument in dry-run logger.info call#2257
Open
Br1an67 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: remove extra argument in dry-run logger.info call#2257Br1an67 wants to merge 1 commit intomicrosoft:mainfrom
Br1an67 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Remove the extraneous True argument from logger.info() in _run_index() which caused a TypeError during string formatting when running graphrag index --dry-run. Fixes microsoft#2254
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the extraneous
Trueargument fromlogger.info("Dry run complete, exiting...", True)in_run_index()which caused aTypeError: not all arguments converted during string formattingwhen runninggraphrag index --dry-run.Related Issues
Fixes #2254
Proposed Changes
Trueargument fromlogger.info()call atcli/index.py:119Checklist
Additional Notes
One-line fix. The
Truewas likely a leftover from a previous API where the second argument controlled some behavior. Standardlogging.info()interprets positional args as format string arguments.