Make generic arrays indexable by `numericStringType` by Andarist · Pull Request #56878 · microsoft/TypeScript

Andarist · 2023-12-26T09:01:41Z

DanielRosenwasser · 2024-01-04T19:58:11Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2024-01-04T19:58:14Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at 012fa84. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-04T19:58:14Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at 012fa84. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-04T19:58:14Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at 012fa84. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-04T19:58:14Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 012fa84. You can monitor the build here.

typescript-bot · 2024-01-04T19:58:14Z

Heya @DanielRosenwasser, I've started to run the regular perf test suite on this PR at 012fa84. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-04T20:00:30Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159269/artifacts?artifactName=tgz&fileId=869C7D363C6CE07F1ABC6FCDDA7B85C8BA51480C313A8D34201EBE6DF87BD99C02&fileName=/typescript-5.4.0-insiders.20240104.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-56878-6".;

typescript-bot · 2024-01-04T20:26:39Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/56878/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-01-04T20:43:42Z

Hey @DanielRosenwasser, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-01-04T21:07:08Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,461k (± 0.01%)}	_{295,490k (± 0.01%)}	_~	_295,446k	_295,527k	_{p=0.128 n=6}
_{Parse Time}	_{2.65s (± 0.15%)}	_{2.65s (± 0.41%)}	_~	_2.64s	_2.67s	_{p=1.000 n=6}
_{Bind Time}	_{0.83s (± 1.01%)}	_{0.83s (± 1.48%)}	_~	_0.81s	_0.84s	_{p=0.928 n=6}
_{Check Time}	_{8.15s (± 0.58%)}	_{8.14s (± 0.21%)}	_~	_8.11s	_8.16s	_{p=0.807 n=6}
_{Emit Time}	_{7.12s (± 0.29%)}	_{7.09s (± 0.25%)}	_{-0.03s (- 0.42%)}	_7.08s	_7.12s	_{p=0.034 n=6}
_{Total Time}	_{18.75s (± 0.32%)}	_{18.71s (± 0.25%)}	_~	_18.65s	_18.78s	_{p=0.226 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,509k (± 1.59%)}	_{191,935k (± 0.56%)}	_~	_191,449k	_194,143k	_{p=0.229 n=6}
_{Parse Time}	_{1.36s (± 1.20%)}	_{1.35s (± 1.85%)}	_~	_1.32s	_1.38s	_{p=0.869 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.25s (± 0.38%)}	_{9.25s (± 0.31%)}	_~	_9.22s	_9.30s	_{p=0.629 n=6}
_{Emit Time}	_{2.62s (± 1.04%)}	_{2.61s (± 0.71%)}	_~	_2.60s	_2.65s	_{p=1.000 n=6}
_{Total Time}	_{13.94s (± 0.43%)}	_{13.94s (± 0.35%)}	_~	_13.88s	_14.01s	_{p=1.000 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,413k (± 0.00%)}	_{347,408k (± 0.01%)}	_~	_347,372k	_347,439k	_{p=0.575 n=6}
_{Parse Time}	_{2.45s (± 0.48%)}	_{2.45s (± 0.54%)}	_~	_2.43s	_2.46s	_{p=0.796 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.595 n=6}
_{Check Time}	_{6.86s (± 0.40%)}	_{6.88s (± 0.50%)}	_~	_6.84s	_6.92s	_{p=0.368 n=6}
_{Emit Time}	_{4.05s (± 0.24%)}	_{4.05s (± 0.33%)}	_~	_4.03s	_4.06s	_{p=0.928 n=6}
_{Total Time}	_{14.29s (± 0.21%)}	_{14.30s (± 0.33%)}	_~	_14.23s	_14.37s	_{p=0.571 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,730k (± 0.01%)}	_{302,725k (± 0.01%)}	_~	_302,702k	_302,749k	_{p=0.572 n=6}
_{Parse Time}	_{2.00s (± 0.82%)}	_{1.99s (± 1.30%)}	_~	_1.95s	_2.02s	_{p=0.367 n=6}
_{Bind Time}	_{1.00s (± 1.55%)}	_{1.01s (± 0.75%)}	_~	_1.00s	_1.02s	_{p=0.281 n=6}
_{Check Time}	_{6.30s (± 0.54%)}	_{6.29s (± 0.45%)}	_~	_6.25s	_6.31s	_{p=0.685 n=6}
_{Emit Time}	_{3.59s (± 0.33%)}	_{3.58s (± 0.34%)}	_~	_3.56s	_3.59s	_{p=0.183 n=6}
_{Total Time}	_{12.88s (± 0.38%)}	_{12.85s (± 0.34%)}	_~	_12.81s	_12.91s	_{p=0.261 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{506,809k (± 0.00%)}	_{506,803k (± 0.00%)}	_~	_506,788k	_506,830k	_{p=0.297 n=6}
_{Parse Time}	_{2.59s (± 0.57%)}	_{2.58s (± 0.35%)}	_~	_2.57s	_2.59s	_{p=0.363 n=6}
_{Bind Time}	_{0.98s (± 1.00%)}	_{0.99s (± 1.64%)}	_~	_0.97s	_1.02s	_{p=0.168 n=6}
_{Check Time}	_{16.91s (± 0.34%)}	_{16.96s (± 0.35%)}	_~	_16.88s	_17.04s	_{p=0.230 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.48s (± 0.31%)}	_{20.53s (± 0.34%)}	_~	_20.45s	_20.62s	_{p=0.228 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,894k (± 0.00%)}	_{512,867k (± 0.01%)}	_~	_512,831k	_512,898k	_{p=0.093 n=6}
_{Parse Time}	_{3.27s (± 0.26%)}	_{3.28s (± 0.26%)}	_~	_3.26s	_3.28s	_{p=1.000 n=6}
_{Bind Time}	_{1.54s (± 0.53%)}	_{1.54s (± 0.27%)}	_~	_1.53s	_1.54s	_{p=1.000 n=6}
_{Check Time}	_{2.82s (± 0.71%)}	_{2.82s (± 0.74%)}	_~	_2.80s	_2.85s	_{p=1.000 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_~	_0.07s	_0.07s	_{p=1.000 n=6}
_{Total Time}	_{7.70s (± 0.35%)}	_{7.70s (± 0.26%)}	_~	_7.69s	_7.73s	_{p=0.935 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,346ms (± 0.92%)}	_{2,339ms (± 0.47%)}	_~	_2,328ms	_2,359ms	_{p=0.872 n=6}
_{Req 2 - geterr}	_{5,453ms (± 1.21%)}	_{5,491ms (± 1.73%)}	_~	_5,364ms	_5,580ms	_{p=0.297 n=6}
_{Req 3 - references}	_{325ms (± 0.71%)}	_{325ms (± 0.74%)}	_~	_322ms	_328ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{274ms (± 1.29%)}	_{273ms (± 1.32%)}	_~	_271ms	_278ms	_{p=0.438 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{92ms (± 4.79%)}	_{90ms (± 5.35%)}	_~	_83ms	_93ms	_{p=0.199 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,476ms (± 1.22%)}	_{2,494ms (± 0.93%)}	_~	_2,457ms	_2,528ms	_{p=0.298 n=6}
_{Req 2 - geterr}	_{4,135ms (± 1.87%)}	_{4,120ms (± 1.41%)}	_~	_4,081ms	_4,237ms	_{p=0.630 n=6}
_{Req 3 - references}	_{336ms (± 1.34%)}	_{343ms (± 1.53%)}	_~	_332ms	_346ms	_{p=0.053 n=6}
_{Req 4 - navto}	_{285ms (± 1.24%)}	_{286ms (± 0.79%)}	_~	_284ms	_290ms	_{p=0.118 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 7.09%)}	_{88ms (± 5.66%)}	_~	_78ms	_91ms	_{p=0.143 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,596ms (± 0.74%)}	_{2,597ms (± 0.68%)}	_~	_2,566ms	_2,616ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{1,745ms (± 1.66%)}	_{1,693ms (± 1.57%)}	_{🟩-53ms (- 3.02%)}	_1,671ms	_1,733ms	_{p=0.013 n=6}
_{Req 3 - references}	_{112ms (±10.09%)}	_{109ms (± 9.86%)}	_~	_101ms	_123ms	_{p=0.510 n=6}
_{Req 4 - navto}	_{362ms (± 1.01%)}	_{365ms (± 0.27%)}	_{+4ms (+ 0.97%)}	_364ms	_367ms	_{p=0.009 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{311ms (± 1.06%)}	_{305ms (± 2.67%)}	_~	_295ms	_313ms	_{p=0.226 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.40ms (± 0.22%)}	_{153.28ms (± 0.22%)}	_{-0.12ms (- 0.08%)}	_152.14ms	_158.34ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.67ms (± 0.15%)}	_{228.57ms (± 0.15%)}	_{-0.09ms (- 0.04%)}	_227.12ms	_232.83ms	_{p=0.002 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.67ms (± 0.20%)}	_{230.69ms (± 0.19%)}	_~	_228.76ms	_237.07ms	_{p=0.509 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.39ms (± 0.19%)}	_{230.37ms (± 0.21%)}	_~	_228.48ms	_237.58ms	_{p=0.514 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-01-04T21:58:59Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/56878/merge:

Everything looks good!

rotu · 2024-02-06T19:14:01Z

FYI, this is overly permissive. Yes, x['10'] should be an allowable index, but 'ob0', '0xf', '001', '+1', '1.000' are all values of ${number} which are not admissible as array indices and probably shouldn't be in ${number}. #57296

Additionally, '0.5', '3e-12', '-0', '-5', are in ${number} legitimately, but are not valid array indices. We should probably check that a string literal satisfies ToIndex.

sandersn · 2025-07-30T22:05:36Z

Comparing this PR to the bug it fixes, I don't think the value is worth the risk/potential work in case of downstream bugs. I'd prefer to close this PR till we see more than 2 upvotes on the bug.

Make generic arrays indexable by numericStringType

012fa84

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Dec 26, 2023

sandersn requested review from DanielRosenwasser and rbuckton January 5, 2024 22:10

sandersn assigned DanielRosenwasser Jan 5, 2024

Andarist mentioned this pull request Jan 22, 2024

Make any[] the effective rest type when any is spread #50034

Closed

Andarist force-pushed the fix/generic-arr-indexable-by-numericstringtype branch from ab72d39 to 012fa84 Compare January 23, 2024 14:29

Andarist closed this Aug 9, 2025

github-project-automation bot moved this from Waiting on reviewers to Done in PR Backlog Aug 9, 2025

microsoft locked as resolved and limited conversation to collaborators Feb 10, 2026

Conversation

Andarist commented Dec 26, 2023

Uh oh!

DanielRosenwasser commented Jan 4, 2024

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

Uh oh!

typescript-bot commented Jan 4, 2024

Uh oh!

typescript-bot commented Jan 4, 2024

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Jan 4, 2024

Uh oh!

rotu commented Feb 6, 2024

Uh oh!

sandersn commented Jul 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

typescript-bot commented Jan 4, 2024 •

edited

Loading

typescript-bot commented Jan 4, 2024 •

edited

Loading

typescript-bot commented Jan 4, 2024 •

edited

Loading

typescript-bot commented Jan 4, 2024 •

edited

Loading

typescript-bot commented Jan 4, 2024 •

edited

Loading

typescript-bot commented Jan 4, 2024 •

edited

Loading