Support generic Uint8Array<ArrayBuffer>#1944
Conversation
02eb871 to
f203df7
Compare
|
This should use ArrayBuffer by default than just overriding some cases, and use SAB+AB when |
|
@sandersn: The implementation changed significantly. Can you take another look? |
|
|
There are still package.json entries for Unfortunately, 5.6 cannot be folded into 5.7+ as use of |
sandersn
left a comment
There was a problem hiding this comment.
Makes sense to me. One question about the change to WritableStream in overridingtypes.json to make sure I understood it correctly.
| "name": "writable", | ||
| "readonly": true, | ||
| "overrideType": "WritableStream<string>" | ||
| "type": "WritableStream", |
There was a problem hiding this comment.
The output doesn't change that I could tell, so I guess this is an update to use the new subtype property for consistency?
There was a problem hiding this comment.
Refraining from overrideType is a good change 👍🏻 (use of overrideType disables type dependency tracking)
There was a problem hiding this comment.
(Though I would have preferred if this kind of change is file as a separate PR, as mixing it makes harder to understand it)
| "name": "writable", | ||
| "readonly": true, | ||
| "overrideType": "WritableStream<string>" | ||
| "type": "WritableStream", |
There was a problem hiding this comment.
(Though I would have preferred if this kind of change is file as a separate PR, as mixing it makes harder to understand it)
saschanaz
left a comment
There was a problem hiding this comment.
Still would like to change gitattributes to use only LF, looks good otherwise!
|
What happened to this PR? Main TS uses this, right? |
|
I believe it's just waiting for you to merge this 😛 |
|
There are merge conflicts but ones I assume will be fixed by regenerating? |
|
Please do so 🙂 (well if I had the permission... 😜) |

This updates the DOM to use
Uint8Array<ArrayBuffer>in some cases where the specification expects it. This addresses an error reported in microsoft/TypeScript#61432 forajayyy/SponsorBlock.This now also fixes
AllowSharedBufferSource, which fails to includeSharedArrayBuffer.Fixes microsoft/TypeScript#61480