Prevent text generation process from overwriting quest's description and game's objective.#240
Merged
MarcCote merged 2 commits intomicrosoft:masterfrom Jun 11, 2020
Merged
Conversation
… and game's objective.
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 82.84% 82.86% +0.01%
==========================================
Files 56 56
Lines 6944 6951 +7
==========================================
+ Hits 5753 5760 +7
Misses 1191 1191
|
gregyoto
added a commit
to gregyoto/TextWorld
that referenced
this pull request
Feb 8, 2026
…exist PR microsoft#240 (fixing microsoft#239) added code to preserve a manually-set objective across build() calls. However, the preservation happens before change_grammar() is called, which unconditionally overwrites the objective via describe_event(). This means the fix only worked for games without quests (no winning policy = no describe_event call). The fix: only auto-generate the objective in change_grammar() if one hasn't already been set (self._objective is None). Fixes microsoft#373 Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #239