Skip to content

Disable dark theme in until chat history has dark theme support#4864

Merged
compulim merged 4 commits intomainfrom
fix-4863-forced-light-mode
Sep 19, 2023
Merged

Disable dark theme in until chat history has dark theme support#4864
compulim merged 4 commits intomainfrom
fix-4863-forced-light-mode

Conversation

@compulim
Copy link
Contributor

@compulim compulim commented Sep 19, 2023

Fixes #4863.

Changelog Entry

Fixed

  • Fixes #4863. Disable dark theme for link references until chat history has dark theme support, by @compulim, in PR #4864

Description

Temporarily disable dark theme until chat history support dark theme.

Otherwise, link references will look weird.

image

And link texts in modal dialog will also look weird.

image

Design

  • DARK_THEME_SELECTOR will always falsy (select nothing)
  • LIGHT_THEME_SELECTOR will be truthy if not in forced colors

Specific Changes

  • Updates Constants to disable dark theme selector
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim linked an issue Sep 19, 2023 that may be closed by this pull request
@compulim compulim marked this pull request as ready for review September 19, 2023 02:33
@compulim compulim added this to the imminent milestone Sep 19, 2023
@compulim compulim merged commit 826765a into main Sep 19, 2023
@compulim compulim deleted the fix-4863-forced-light-mode branch September 19, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Link reference] Add forced light/dark mode so they don't mix

2 participants