add LinkText and underline to HC button-link#4537
Merged
Conversation
compulim
approved these changes
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ADO issue 15603122 (https://msazure.visualstudio.com/CCI/_workitems/edit/15603122)
Changelog Entry
Fixed
Description
High-contrast themes like Desert and Aquatic render button text in the same color as ordinary text. This is a problem when we use a button to mimic a link (as we do in InlineMarkdown), because then the text blends into the surrounding text.
Specific Changes
This adds a @media forced-colors selector to InlineMarkdown that adds the semantic LinkText color and a single underline to links that have been turned from Markdown into buttons; this makes them visually distinct.
[in draft until there are unit tests]
CHANGELOG.mdReview Checklist
Browser and platform compatibilities reviewedz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)