Bump deps after releasing 4.15.3#4392
Merged
compulim merged 12 commits intomicrosoft:mainfrom Aug 14, 2022
Merged
Conversation
compulim
commented
Aug 12, 2022
compulim
commented
Aug 12, 2022
compulim
commented
Aug 12, 2022
compulim
commented
Aug 12, 2022
compulim
commented
Aug 12, 2022
compulim
commented
Aug 12, 2022
packages/component/src/LiveRegion/private/LiveRegionSuggestedActions.tsx
Show resolved
Hide resolved
cwhitten
approved these changes
Aug 12, 2022
This was referenced Sep 7, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
@babel/runtime@7.18.9@emotion/css@11.10.0core-js@3.24.1markdown-it-attrs@4.1.4markdown-it@13.0.1redux@4.2.0sanitize-html@2.7.1@babel/cli@7.18.10@babel/core@7.18.10@babel/plugin-proposal-class-properties@7.18.6@babel/plugin-proposal-object-rest-spread@7.18.9@babel/plugin-transform-runtime@7.18.10@babel/plugin-transform-typescript@7.18.12@babel/preset-env@7.18.10@babel/preset-react@7.18.6@babel/preset-typescript@7.18.6@babel/runtime@7.18.9@emotion/react@11.10.0@fluentui/react@8.87.1@types/node@18.7.1@types/react@18.0.17@typescript-eslint/eslint-plugin@5.33.0@typescript-eslint/parser@5.33.0babel-jest@28.1.3babel-loader@8.2.5babel-plugin-transform-inline-environment-variables@0.4.4concurrently@7.3.0core-js@3.24.1dotenv@16.0.1error-stack-parser@2.1.4esbuild@0.15.1eslint-plugin-prettier@4.2.1eslint-plugin-react-hooks@4.6.0eslint-plugin-react@7.30.1eslint-plugin-security@1.5.0eslint@8.21.0express@4.18.1http-proxy-middleware@2.0.6husky@8.0.1jest-environment-node@28.1.3jest-image-snapshot@5.1.0jest-junit@14.0.0jest-trx-results-processor@3.0.1jest@28.1.3lerna@5.4.0lint-staged@13.0.3node-dev@7.4.3nodemon@2.0.19nopt@6.0.0prettier@2.7.1react-scripts@5.0.1selenium-webdriver@4.4.0serve@14.0.1source-map-loader@4.0.0strip-ansi@7.0.1terser-webpack-plugin@5.3.3typescript@4.7.4webpack-cli@4.10.0webpack@5.74.0Description
Bump dependencies after releasing 4.15.3.
Update to TypeScript triggered some errors which were previously green. The errors are legit and we need fix some typings in our code instead.
Skip-bump
react-reduxas8.0.2is not ES5.Design
Jest 28 with
jest-environment-jsdomand ESMMost package developers are aware that "package consumed in browser" means "package will be processed by Webpack/ESBuild/Rollup/etc." That means, it is okay to use either CommonJS or ESM for module resolution.
ESM is preferred because it could potentially provide better treeshaking.
Thus, many packages export itself as ESM when the consumer is a browser, i.e. via
package.json/exports/./default. For example,uuidis a package which export itself as ES5 + ESM when the consumer is a browser.When
jest-environment-jsdomresolves a package, it pretend to be a browser. That means, packages resolved underjest-environment-jsdomtest environment could be ESM, because the package expose ESM for browser.As
jest@28does not support ESM yet (behind experimental flag), that means, using default configuration, packages resolved byjest-environment-jsdomcould be in ESM and Jest will not be able to execute them.Quick thinking, there are a few ways to solve the issue:
testEnvironmentOptionswith{ "customExportConditions": ["node"] }to resolve imports as "node" condition, which is "more likely" to be CommonJStransformIgnorePatternto whitelist packages that need to be transformedWe are using point 3 because:
Specific Changes
npm run bumpon all packages.ts/.tsxjest-environment-jsdomas it is no longer included injest@28react-reduxtoskipBumpas its8.0.1is not a ES5 packageCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)CSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)