Update code on Update Book form lesson#28334
Merged
Conversation
A code improvement. The constant that named the updated book in the process didn't had a name that was descriptive enough.
Contributor
Collaborator
|
@marcusicaro I generally don't accept this kind of change unless it is accompanied by a change to the associated worked example project: https://github.com/mdn/express-locallibrary-tutorial . Having a demo that matches the tutorial makes it much easier to verify whether (future) issues posted against the tutorial are real, or just errors in following the instructions. Can you please create a PR to fix that up as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A code improvement. The constant that named the updated book in the process didn't had a name that was descriptive enough.
Description
Code improvement.
A code improvement to make the name of a constant more clear.
Motivation
Improving the quality of the MDN material.
It describes better what that constant is and what it does.
Additional details
Related issues and pull requests