Add a few more options for self-hosting#833
Conversation
|
@kylewlacy is attempting to deploy a commit to the Caravel Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for your contribution @kylewlacy, this is great. We will review this shortly and get back to you. |
A fix was already pushed upstream that made this setting unnecessary
|
I pushed a few extra changes to resolve merge conflicts, to add support for setting |
|
Alright, just added one more change, which I think this is the final one I needed for my self-hosting setup. The new option is the |
|
Hi @kylewlacy, The PR looks good I have approved it we will merge it shortly to our develop branch. Thanks for your contribution. |
This PR adds a few more settings to address some papercuts I ran into while I was setting up a self-hosted instance of Plane.
Just to go over the changes:
$EMAIL_USE_TLSto optionally disable TLS when sending emails via SMTP. I added this because I have been using MailHog to test email delivery locally (which doesn't support TLS as far as I cant tell).$EMAIL_PORTchange the port used when sending emails via SMTP. Port 587 still seems like the right default, but my understanding is that there's not even consensus that this is the "one true" SMTP port. Again, I added this because of MailHog (which uses port 1025 by default).$EMAIL_FROMto set the sender name/address. I needed this so I could switch over to sending emails through a real SMTP server (AWS SES in my case).AddedI added this in the first version of the PR, but removed it since a fix for this issue already landed on$REDIS_BROKER_SSLto optionally disable the extra TLS settings that are added to the Celery Redis connection string.develop.$AWS_S3_ENDPOINT_URLto set the setting of the same name. I used this to use SeaweedFS for file uploads while self-hosting.$NEXT_PUBLIC_EXTRA_IMAGE_DOMAINS. This option is used to add more domains (comma-separated) to thenext/imagesconfig. Without this setting, I wasn't able to actually use the images that were being uploaded to S3 (avatar URLs, for example).