feat: added monitoring for postgres query result#6736
feat: added monitoring for postgres query result#6736CommanderStorm merged 2 commits intolouislam:masterfrom
Conversation
CommanderStorm
left a comment
There was a problem hiding this comment.
Looks very much like the code in the other db-like monitors 👍🏻
Thanks for implementing this and adding the testcases!
|
#6794 should be broken by this. Is it an AI pull request? Is it really tested? I am planning to release 2.1.0 soon. The test file probably doesn't cover all cases. If no one test on Postgres manually, it will be reverted. |
|
@louislam let's revert it and put the change into 2.2. |
|
Sorry I’m on vacation currently, I did test that case I thought so I’m confused as to why it’s broken. I’ll take a look next week when I get back, sorry about that. |
|
So when testing locally on my branch and on 3.0.X(baaf14c) I get the expected behavior with "SELECT 1" as well as an empty query field with no conditions returns an "UP" status. Investigating further. |
Summary
In this pull request, the following changes are made:
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
Screenshots for Visual Changes