Skip to content

feat: added monitoring for postgres query result#6736

Merged
CommanderStorm merged 2 commits intolouislam:masterfrom
daltonpearson:feature/monitor-postgres-query-result
Jan 14, 2026
Merged

feat: added monitoring for postgres query result#6736
CommanderStorm merged 2 commits intolouislam:masterfrom
daltonpearson:feature/monitor-postgres-query-result

Conversation

@daltonpearson
Copy link
Contributor

@daltonpearson daltonpearson commented Jan 14, 2026

Summary

In this pull request, the following changes are made:

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

Screenshots for Visual Changes

  • UI Modifications: Highlight any changes made to the user interface.

@daltonpearson daltonpearson changed the title added monitoring for postgres query result feat: added monitoring for postgres query result Jan 14, 2026
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very much like the code in the other db-like monitors 👍🏻

Thanks for implementing this and adding the testcases!

@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 14, 2026
@CommanderStorm CommanderStorm merged commit d7296c6 into louislam:master Jan 14, 2026
28 checks passed
@louislam
Copy link
Owner

louislam commented Jan 25, 2026

#6794 should be broken by this.

Is it an AI pull request? Is it really tested?

I am planning to release 2.1.0 soon. The test file probably doesn't cover all cases. If no one test on Postgres manually, it will be reverted.

@CommanderStorm
Copy link
Collaborator

@louislam let's revert it and put the change into 2.2.
I did not manually test since the tests seemed solid.

@daltonpearson
Copy link
Contributor Author

Sorry I’m on vacation currently, I did test that case I thought so I’m confused as to why it’s broken. I’ll take a look next week when I get back, sorry about that.

@daltonpearson
Copy link
Contributor Author

So when testing locally on my branch and on 3.0.X(baaf14c) I get the expected behavior with "SELECT 1" as well as an empty query field with no conditions returns an "UP" status. Investigating further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Monitor Postgres query result

3 participants