feat: add sorting to status pages#5766
Conversation
|
Sorry, a +1.1k rewrite of one component implementing different features is not reviewable. Looking at the screenshot:
|
There was a problem hiding this comment.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/lang/en.json: Language not supported
- src/lang/zh-CN.json: Language not supported
Comments suppressed due to low confidence (1)
src/pages/StatusPage.vue:778
- The new monitor reordering logic would benefit from unit test coverage to ensure that monitors are ordered correctly under various heartbeat conditions.
if (!this.enableEditMode) {
5564fc2 to
436ac1b
Compare
|
Hi @CommanderStorm , Thanks for the feedback!
I'll split the PR into smaller, more focused changes. I'll also add some necessary comments to make the logic clearer.
I'll update the UI to better match the existing style—thanks for pointing that out.
Do you have any suggestions regarding the sorting feature? I’ll revise the implementation based on your suggestions and follow up with updated PRs soon. Thanks again! BR, |
Yes, please do that. That has the addtional advantage of simplifies the PR ^^
That sounds reasonable. Maybe |
Yes, that is approximately what I was thinking about. |
|
Hi @CommanderStorm , Thank you for your suggestions. Based on your advice, I have made the following adjustments. For the adjustments to the sortingRemoved the search functionality and global sorting. The group sorting options are now displayed through a dropdown button, as shown in the image below. I replaced the "Sort by" text on the button with an upward arrow and a downward arrow. When no sorting option is selected, both arrows are gray. When the sorting is in ascending order, the upward arrow turns green; otherwise, the downward arrow turns green. Allow switching between ascending and descending order by clicking the already selected sorting attribute again. Support for link-sharing of personal sortingImplemented the link-sharing feature. When others visit this link, they will see the same sorting effects. The current pull request is half the size of the original pull request, please check it when you have time. Thanks! |
|
Thanks for the review and detailed feedback! Just saw this I’ll go through the comments and update accordingly soon. |
|
Hi @CommanderStorm, Sorry for the long delay in responding to your review. I had to switch to my corporate email for this contribution due to company policy requirements, which took some time to get approved through our internal processes. I’ve now addressed all your review comments. Thanks for your patience and the detailed reviews, they really helped improve the code quality. Looking forward to your feedback. Best regards, |
|
Hi @CommanderStorm, do you have any review comments or suggestions for the next steps? Thanks! |
|
sorry, I have been super buisy with non-uptime-kuma things. I would appreciated if other people could test-drive this PR. |
efcf154 to
25d8e54
Compare
|
Hi @CommanderStorm, Sorry for the late reply, and thanks again for your previous message. I just wanted to gently check in on this PR and see if there’s anything I can do to help move it forward. I’m happy to update the code or run any additional tests if needed. Thanks again! |
|
The feature works really nicely and I would love to have it |
Thanks for the comment! I've fixed this issue. The current fix uses the group’s backend ID (or the index if no ID is available) as the unique key, which resolves the issue on the status page where groups with the same name were incorrectly coupled in sorting. Please bother to help review it again if you have time, and let me know if there are any comments, Thanks! |
CommanderStorm
left a comment
There was a problem hiding this comment.
Nice work!
Thank you for impelementing this improvement 🎉
|
Thanks again for reviewing and merging this PR! Building on the status page improvements here, I’ve opened a separate PR (#6452) that adds a simple search/filter for monitors. This makes it easier to quickly find a specific monitor on large status pages. The PR description has more details. If you have some time, I’d really appreciate it if you could take a look when convenient. Thanks! |










This PR implements group and global sorting and searching features with corresponding UI improvements. Resolves #1936.
Features
Additional Notes
Closes #1936