Restore default dark mode & fix migration for 3.x / 4.x users#514
Merged
marionbarker merged 1 commit intodevfrom Jan 30, 2026
Merged
Restore default dark mode & fix migration for 3.x / 4.x users#514marionbarker merged 1 commit intodevfrom
marionbarker merged 1 commit intodevfrom
Conversation
codebymini
approved these changes
Jan 30, 2026
marionbarker
requested changes
Jan 30, 2026
Collaborator
There was a problem hiding this comment.
Summary
Ignore this comment - error in test plan
This does not do the modification that is desired.
Test Plan with Results
- ✅ delete LoopFollow from phone, ensure that default appearance is dark
- ✅ build version 4.4.0 (main), leave forceDarkMode enabled, build this branch, ensure
darkis the selected appearance option - ❌ build version 4.4.0 (main), select forceDarkMode disabled, quit/restart ensure light mode, build this branch, ❌ ensure
systemis the selected appearance option- ❌ appearance setting is dark, expect system
test plan not completed
- build version 2.6.0, leave forceDarkMode enabled, build this branch, ensure
darkis the selected appearance option - build version 2.6.0, select forceDarkMode disabled, build this branch, ensure
systemis the selected appearance option
marionbarker
approved these changes
Jan 30, 2026
Collaborator
marionbarker
left a comment
There was a problem hiding this comment.
Summary
With a properly configured test plan, this PR provides proper migration.
Updated the Test Plan - previous version did not delete the app completely before returning to an earlier version; leaving behind legacy values from the previous migration.
Test Plan with Results
- ✅ delete LoopFollow from phone, build this branch, ensure that default appearance is dark
- Prerequisite for each migration test - delete LoopFollow from phone to remove stored legacy values
- ✅ build version 4.4.0 (main), leave forceDarkMode enabled, build this branch, ensure
darkis the selected appearance option
- ✅ build version 4.4.0 (main), leave forceDarkMode enabled, build this branch, ensure
- Prerequisite for each migration test - delete LoopFollow from phone to remove stored legacy values
- ✅ build version 4.4.0 (main), select forceDarkMode disabled, quit/restart ensure light mode, build this branch, ensure
systemis the selected appearance option
- ✅ build version 4.4.0 (main), select forceDarkMode disabled, quit/restart ensure light mode, build this branch, ensure
- Prerequisite for each migration test - delete LoopFollow from phone to remove stored legacy values
- ✅ build version 2.6.0, leave forceDarkMode enabled, build this branch, ensure
darkis the selected appearance option
- ✅ build version 2.6.0, leave forceDarkMode enabled, build this branch, ensure
- Prerequisite for each migration test - delete LoopFollow from phone to remove stored legacy values
- ✅ build version 2.6.0, select forceDarkMode disabled, build this branch, ensure
systemis the selected appearance option
- ✅ build version 2.6.0, select forceDarkMode disabled, build this branch, ensure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change restores dark mode as the default appearance and fixes a migration issue affecting users on 3.x and 4.x.
Previously, the migration logic only handled users upgrading from pre-3.0 versions. As a result, users already on 3.x or 4.x could lose their expected appearance setting during migration.
What’s changed
.dark) as the default value forappearanceModeforceDarkModestored viaStorageValuetrue→.darkfalse→.systemWhy
Impact