Add option to silence alarm with volume button#447
Merged
marionbarker merged 20 commits intoloopandlearn:devfrom Oct 1, 2025
Merged
Add option to silence alarm with volume button#447marionbarker merged 20 commits intoloopandlearn:devfrom
marionbarker merged 20 commits intoloopandlearn:devfrom
Conversation
codebymini
added a commit
to CodeByMiniOrg/LoopFollow
that referenced
this pull request
Sep 30, 2025
marionbarker
approved these changes
Oct 1, 2025
Collaborator
There was a problem hiding this comment.
This has been used in-vivo by two of the developers.
Do a quick test by triggering an alarm and observing that pressing one-time on either a volume button snoozes the alarm when the feature is enable.
EDIT: the description has been updated.
The only issue is the description of the PR says enabled by default, when in fact it is disabled by default. But very first alarm that came on was snoozed right away and log said it was the volume button that stopped it. However, that seemed to be a one-time thing. I then changed to enabled. Quit and restart the app. Then volume buttons snoozed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces enhancements to the LoopFollow app's alarm management system: volume button alarm silencing.
Features Added
Volume Button Alarm Silencing
Technical Implementation
Volume Button Handler
VolumeButtonHandler.swift(327 lines)Configuration
New Settings
Default Behavior
Testing & Reliability
Volume Button Detection