feat: add user-configurable tab customization for tabs 2 and 4#433
Closed
feat: add user-configurable tab customization for tabs 2 and 4#433
Conversation
Contributor
Author
ScreenRecording_07-08-2025.21-17-14_1.MP4 |
codebymini
approved these changes
Jul 8, 2025
Collaborator
codebymini
left a comment
There was a problem hiding this comment.
👍 Looks and work great
|
This is looking great. I still do use all 6 function though. |
Collaborator
|
General comment about the design. If tab selection is such that either Remote or Nightscout is not selected for one of the tabs, there is no way to get to that screen. The alarms can be reached using the alarm row under settings. |
Contributor
Author
|
I am working on another suggestion, hold on.. |
Merged
Contributor
Author
|
Closing this one in favor for #437 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements user-configurable tab customization, allowing users to select what appears in tabs 2 and 4 of the tab bar. Previously, tab 2 was dynamically set based on whether remote was enabled, but now users have full control over their tab arrangement.
Changes
TabSelectionenum to centralize tab configuration (display name, SF symbol, storyboard identifier)tab2Selectionandtab4Selectionwith defaults (Alarms and Nightscout respectively)TabCustomizationSettingsViewfor users to configure their tab preferencesMainViewControllerto use the new dynamic tab systemUser Experience
Users can now go to Settings → App Settings → Tab Customization to choose what appears in tabs 2 and 4 from:
The fixed tabs remain:
Migration
Existing users will have their preferences preserved:
Testing
Closes #333