[lit] Fix filter-failed-rerun.py on readonly FSes#177075
Merged
boomanaiden154 merged 1 commit intollvm:mainfrom Jan 21, 2026
Merged
[lit] Fix filter-failed-rerun.py on readonly FSes#177075boomanaiden154 merged 1 commit intollvm:mainfrom
boomanaiden154 merged 1 commit intollvm:mainfrom
Conversation
This test invokes lit in a directory and then tries to overwrite fail.txt within that directory. With the project sources mounted as read-only, fail.txt ends up being marked readonly, which causes cp to fail without -f. Use cp -f to ensure we overwrite the existing fail.txt.
Member
|
@llvm/pr-subscribers-testing-tools Author: Aiden Grossman (boomanaiden154) ChangesThis test invokes lit in a directory and then tries to overwrite fail.txt within that directory. With the project sources mounted as read-only, fail.txt ends up being marked readonly, which causes cp to fail without -f. Use cp -f to ensure we overwrite the existing fail.txt. Full diff: https://github.com/llvm/llvm-project/pull/177075.diff 1 Files Affected:
diff --git a/llvm/utils/lit/tests/filter-failed-rerun.py b/llvm/utils/lit/tests/filter-failed-rerun.py
index 7db12c26a02ff..1513f638371f7 100644
--- a/llvm/utils/lit/tests/filter-failed-rerun.py
+++ b/llvm/utils/lit/tests/filter-failed-rerun.py
@@ -6,7 +6,7 @@
#
# RUN: not %{lit} %t | FileCheck %s --check-prefix=CHECK-FIRST
#
-# RUN: cp %t%{fs-sep}pass.txt %t%{fs-sep}fail.txt
+# RUN: cp -f %t%{fs-sep}pass.txt %t%{fs-sep}fail.txt
# RUN: not %{lit} %t | FileCheck %s --check-prefix=CHECK-SECOND
# RUN: not %{lit} --filter-failed %t | FileCheck %s --check-prefix=CHECK-THIRD
|
rupprecht
approved these changes
Jan 21, 2026
BStott6
pushed a commit
to BStott6/llvm-project
that referenced
this pull request
Jan 22, 2026
This test invokes lit in a directory and then tries to overwrite fail.txt within that directory. With the project sources mounted as read-only, fail.txt ends up being marked readonly, which causes cp to fail without -f. Use cp -f to ensure we overwrite the existing fail.txt.
Harrish92
pushed a commit
to Harrish92/llvm-project
that referenced
this pull request
Jan 23, 2026
This test invokes lit in a directory and then tries to overwrite fail.txt within that directory. With the project sources mounted as read-only, fail.txt ends up being marked readonly, which causes cp to fail without -f. Use cp -f to ensure we overwrite the existing fail.txt.
Harrish92
pushed a commit
to Harrish92/llvm-project
that referenced
this pull request
Jan 24, 2026
This test invokes lit in a directory and then tries to overwrite fail.txt within that directory. With the project sources mounted as read-only, fail.txt ends up being marked readonly, which causes cp to fail without -f. Use cp -f to ensure we overwrite the existing fail.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test invokes lit in a directory and then tries to overwrite fail.txt within that directory. With the project sources mounted as read-only, fail.txt ends up being marked readonly, which causes cp to fail without -f. Use cp -f to ensure we overwrite the existing fail.txt.