CI: Set token for security jobs in e2e test workflow#475
Merged
ykim-akamai merged 1 commit intolinode:devfrom Nov 13, 2024
Merged
CI: Set token for security jobs in e2e test workflow#475ykim-akamai merged 1 commit intolinode:devfrom
ykim-akamai merged 1 commit intolinode:devfrom
Conversation
ykim-akamai
added
the
repo-ci-improvement
ykim-akamai
requested review from
ezilber-akamai and
zliang-akamai
and removed request for
a team
Member
|
Is it possible to set the secrete via |
ezilber-akamai
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Forgot to set token for the security jobs e.g. apply-calico-rules, add-fw-to-remaining-instances
✔️ How to Test
Passed on CLI repo which is using basically the same code: https://github.com/linode/linode-cli/actions/runs/11708470979
Forked run - https://github.com/ykim-akamai/linode_api4-python/actions/runs/11808463187 (Test failures are not related)
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.