test: Add job in E2E CI to attach firewall to any remaining instances#468
Merged
ykim-akamai merged 2 commits intolinode:devfrom Nov 12, 2024
Conversation
ykim-akamai
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
yec-akamai
reviewed
Nov 1, 2024
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
LGTM. Is the forked run available now?
Contributor
Author
Yeah I included the latest CLI run which includes essentially the same jobs after test execution |
jriddle-linode
approved these changes
Nov 1, 2024
Collaborator
jriddle-linode
left a comment
jriddle-linode
left a comment
There was a problem hiding this comment.
LGTM, firewalls everywhere!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adding
add-fw-to-remaining-instancesjob to E2E CIs to ensure all remaining instances or nodes have CFW attached✔️ How to Test
Passing on CLI integration workflow, the job is essentially the same - https://github.com/linode/linode-cli/actions/runs/11634047963
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.