test: Add retry on flaky tests#458
Merged
ykim-akamai merged 3 commits intolinode:devfrom Sep 25, 2024
Merged
Conversation
Contributor
lgarber-akamai
approved these changes
Sep 20, 2024
Contributor
lgarber-akamai
left a comment
There was a problem hiding this comment.
The test failures in the linked suite run look unrelated and the relevant tests are passing on my end, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Following list of tests failed occasionally in recent builds, refer to TOD for details.
This PR uses existing pytest library called
pytest-rerunfailuresto rerun tests with delay. Flaky tests now can simply be marked with@pytest.mark.flaky(reruns=3, reruns_delay=2)✔️ How to Test
This retry logic can be tested with simply forcing one of the tests listed above to fail. (E.g. Insert
assert Falsein top section of the test) then run that following test using command like below.make TEST_CASE="test_lke_cluster_labels_and_taints -s" testintEach retry should be marked with "R" in terminal
e.g.
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.