fix: Added missing LDE argument to disk_create#456
Merged
ezilber-akamai merged 1 commit intolinode:devfrom Sep 12, 2024
Merged
Conversation
ezilber-akamai
requested review from
jriddle-linode and
zliang-akamai
and removed request for
a team
ezilber-akamai
changed the title
disk_createdisk_create
ykim-akamai
requested review from
a team,
yec-akamai and
ykim-akamai
and removed request for
a team
ykim-akamai
approved these changes
Sep 12, 2024
Contributor
ykim-akamai
left a comment
ykim-akamai
left a comment
There was a problem hiding this comment.
LGTM, tests are passing locally. Thanks for the quick fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added
disk_encryptionargument todisk_createto prevent it from being interpreted asstackscript_args.✔️ How to Test
Unit Tests
make testunitIntegration Tests
pytest test/integration/models/linode/test_linode.py -k test_linode_create_disk