Added support for Block Storage Encryption#453
Merged
ezilber-akamai merged 4 commits intolinode:devfrom Oct 14, 2024
Merged
Conversation
ezilber-akamai
added
new-feature
ezilber-akamai
changed the title
ezilber-akamai
removed
the
do-not-merge
ezilber-akamai
requested review from
jriddle-linode and
ykim-akamai
and removed request for
a team
yec-akamai
approved these changes
Oct 14, 2024
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
Tests passed locally, nice work!
lgarber-akamai
approved these changes
Oct 14, 2024
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Works well on my end after configuring my account for Block Storage Disk Encryption, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for Block Storage Encryption across the following endpoints:
✔️ How to Test
After checking out this PR locally, run the following tests:
make testunitmake TEST_CASE="test_get_volume_with_encryption" testintmake TEST_CASE="test_linode_with_block_storage_encryption" testint