Fixed inconsistent value types populated for LKENodePool.nodes#446
Merged
ezilber-akamai merged 2 commits intolinode:devfrom Aug 1, 2024
Merged
Conversation
ezilber-akamai
requested review from
lgarber-akamai and
yec-akamai
and removed request for
a team
…h LKENodePoolNode objects
ezilber-akamai
force-pushed
the
TPT-2967-lke-node-pool-types
branch
from
72a4610 to
642e3cb
Compare
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Would it make sense to add some unit test cases to test that all accepted types are properly translated to LKENodePoolNode objects? Otherwise looks perfect
Contributor
Author
Fixed! |
lgarber-akamai
approved these changes
Jul 31, 2024
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Tests are passing on my end, great work!
yec-akamai
approved these changes
Jul 31, 2024
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
Nice work adding the unit tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Updated The LKENodePool(...).nodes attribute to only be populated with LKENodePoolNode objects.
✔️ How to Test
Integration Tests
make testint TEST_SUITE=lkeUnit Tests
make testunit