Skip to content

Comments

v5.19.0#442

Merged
jriddle-linode merged 10 commits intomainfrom
dev
Jul 24, 2024
Merged

v5.19.0#442
jriddle-linode merged 10 commits intomainfrom
dev

Conversation

@jriddle-linode
Copy link
Collaborator

@jriddle-linode jriddle-linode commented Jul 22, 2024

No description provided.

@jriddle-linode jriddle-linode added ignore-for-release PRs you do not want to render in the changelog do-not-merge PRs that should not be merged until the commented issue is resolved labels Jul 22, 2024
@jriddle-linode jriddle-linode requested a review from a team as a code owner July 22, 2024 17:49
@jriddle-linode jriddle-linode requested review from yec-akamai and zliang-akamai and removed request for a team July 22, 2024 17:49
jriddle-linode and others added 5 commits July 23, 2024 11:15
@jriddle-linode
Update api doc urls to point to techdocs (#439)
72481ad 
## 📝 Description

**What does this PR do and why is this change necessary?**

Updates any api doc urls to point to https://techdocs.akamai.com/linode-api/reference/api
@lgarber-akamai
Add LDE LA disclaimer
e7f3fc9
@lgarber-akamai
Merge branch 'dev' into proj/disk-encryption
9486d67
@lgarber-akamai
Merge pull request #436 from linode/proj/disk-encryption
c786ecf 
project: Linode Disk Encryption (re-apply)
@lgarber-akamai
test: Temporarily disable LDE integration tests (#444)
536118a 
* Temporarily disable LDE tests

* various fixes
@lgarber-akamai
Copy link
Contributor

lgarber-akamai commented Jul 23, 2024

Failing tests are due to intermittent issues & leaked test resources:

python3 -m pytest test/integration/models/firewall/test_firewall.py::test_get_devices  
========================================================================== test session starts ==========================================================================
platform darwin -- Python 3.11.9, pytest-8.0.0, pluggy-1.4.0
rootdir: /Users/lgarber/Projects/dx-devenv/repos/linode_api4-python
collected 1 item                                                                                                                                                        

test/integration/models/firewall/test_firewall.py .                                                                                                               [100%]

=========================================================================== 1 passed in 2.62s ===========================================================================

python3 -m pytest test/integration/models/vpc/test_vpc.py::test_fails_update_subnet_invalid_data  
========================================================================== test session starts ==========================================================================
platform darwin -- Python 3.11.9, pytest-8.0.0, pluggy-1.4.0
rootdir: /Users/lgarber/Projects/dx-devenv/repos/linode_api4-python
collected 1 item                                                                                                                                                        

test/integration/models/vpc/test_vpc.py .                                                                                                                         [100%]

=========================================================================== 1 passed in 1.73s ===========================================================================

lgarber-akamai
lgarber-akamai approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ezilber-akamai ezilber-akamai self-requested a review July 23, 2024 19:28
@jriddle-linode jriddle-linode removed the do-not-merge PRs that should not be merged until the commented issue is resolved label Jul 24, 2024
@jriddle-linode jriddle-linode merged commit bc9f123 into main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@zliang-akamai zliang-akamai zliang-akamai approved these changes

@ezilber-akamai ezilber-akamai ezilber-akamai approved these changes

@yec-akamai yec-akamai Awaiting requested review from yec-akamai yec-akamai is a code owner automatically assigned from linode/dx

Assignees

No one assigned

Labels

ignore-for-release PRs you do not want to render in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jriddle-linode @lgarber-akamai @zliang-akamai @ezilber-akamai @ykim-akamai