fix use updated finalized_slot for justifiability#443
Merged
tcoratger merged 5 commits intoleanEthereum:mainfrom Mar 10, 2026
Merged
Conversation
Collaborator
|
@bomanaps To avoid this behaviour to happen again, could we have a simple unit test or even better a test vector to flag this behaviour? Meaning a test that didn't pass before and that passes now. |
Contributor
Author
Added the test vector |
tcoratger
reviewed
Mar 10, 2026
tcoratger
reviewed
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
The justifiability checks were using self.latest_finalized.slot which remains immutable during attestation processing, causing different finalization behavior when votes are packed in one block versus spread across multiple blocks, this fix changes lines 489 and 543 to use the mutable finalized_slot variable that gets updated when finalization advances mid-loop, this aligns with the original 3sf-mini spec behavior at https://github.com/ethereum/research/blob/master/3sf-mini/consensus.py where state.latest_finalized_slot is updated and immediately visible to subsequent votes in the same block.
🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox