Merged
Conversation
tanderson-ld
requested review from
a team,
cwaldren-ld and
louis-launchdarkly
and removed request for
louis-launchdarkly
cwaldren-ld
reviewed
Apr 24, 2024
| - uses: ./.github/actions/full-release | ||
| with: | ||
| workspace_path: lib/java-server-sdk-otel | ||
| dry_run: true #TODO make this false |
Contributor
Author
There was a problem hiding this comment.
Thanks. My intention is to merge this and test things out first.
tanderson-ld
commented
Apr 25, 2024
| /production/common/releasing/sonatype/password = SONATYPE_PASSWORD, | ||
| /production/common/releasing/android_code_signing/private_key_id = SIGNING_KEY_ID, | ||
| /production/common/releasing/android_code_signing/private_key_passphrase = SIGNING_KEY_PASSPHRASE' | ||
| s3_path_pairs: 'launchdarkly-releaser/android/code-signing-keyring.gpg = code-signing-keyring.gpg' |
Contributor
Author
There was a problem hiding this comment.
For reviewers: This was part of testing secrets redaction that merged to main temporarily. Is now removed.
tanderson-ld
commented
Apr 25, 2024
|
|
||
| -name: Echo Test | ||
| shell: bash | ||
| run: echo ${{ inputs.echo_test }} |
Contributor
Author
There was a problem hiding this comment.
For reviewers: This was part of testing secrets redaction that merged to main temporarily. Is now removed.
tanderson-ld
commented
Apr 25, 2024
| required: false | ||
| default: 'temurin' | ||
| echo_test: | ||
| required: false |
Contributor
Author
There was a problem hiding this comment.
For reviewers: This was part of testing secrets redaction that merged to main temporarily. Is now removed.
cwaldren-ld
approved these changes
Apr 25, 2024
1 task
tanderson-ld
added a commit
that referenced
this pull request
Feb 12, 2026
…fication (#136) **Requirements** - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) **Related issues** N/A **Describe the solution you've provided** Adds a new GitHub Actions workflow that runs the Java server SDK contract tests nightly (4am UTC) with the `-enable-long-running-tests` flag enabled. If the tests fail, a Slack notification is sent to alert the team. Key details: - **Schedule**: Runs daily at 4am UTC via cron, with `workflow_dispatch` for manual triggering (supports custom branch and Slack test notification inputs) - **Test execution**: Reuses the existing `ci` and `contract-tests` composite actions; the `contract-tests` action now accepts a `test_harness_params` input to pass `-enable-long-running-tests` - **Slack notification**: Uses `slackapi/slack-github-action` (pinned to v2.1.1 SHA) with an incoming webhook (`SLACK_WEBHOOK_URL` secret) to post to Slack on failure, including a link to the failed run - **Test Slack job**: A separate `test-slack-notification` job can be triggered manually via `workflow_dispatch` to verify the Slack integration is working - **Contract test service updates**: Added `server-side-polling` capability and polling parameter support to the test service entity - **FDv2 suppressions**: Three `streaming/fdv2` fallback/recovery tests are suppressed pending spec alignment between Go and Java implementations **Items for reviewer attention:** 1. **`SLACK_WEBHOOK_URL` secret** — must be configured in the repo settings with a webhook routed to `#sdks-java`. The channel is determined by the webhook configuration, not the workflow. 2. **No `timeout-minutes`** — long-running tests could potentially hang indefinitely. Consider adding a timeout. 3. **Notification scope** — the Slack job triggers on `failure` only, not `cancelled` or `timed_out`. Decide if those states should also notify. 4. **Contract test service changes** — verify the new polling support in `SdkClientEntity.java` is correct, particularly the conditional logic for `params.polling != null && params.dataSystem == null` and the base URI endpoint wiring. **Describe alternatives you've considered** - Could use `rtCamp/action-slack-notify` (used by `ldcli`) instead of `slackapi/slack-github-action`, but the official Slack action is more widely used across LD repos (`terraform-provider-launchdarkly`, `streamer`, `ld-docs-private`). **Updates since initial revision** - Extended `contract-tests` composite action with `test_harness_params` input instead of splitting out individual make targets (addresses original item #4) - Added `workflow_dispatch` inputs for branch selection and Slack notification testing - Added `test-slack-notification` job for verifying Slack integration - Added `server-side-polling` capability and polling params to the contract test service - Added 3 FDv2 streaming fallback/recovery test suppressions (pending spec alignment) - Pinned `slackapi/slack-github-action` to v2.1.1 SHA (`91efab103c0de0a537f72a35f6b8cda0ee76bf0a`) **Additional context** [Link to Devin run](https://app.devin.ai/sessions/9fb4e81a67fd47098803d5d7dabd008b) Requested by: tanderson@launchdarkly.com <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Primarily CI/workflow changes, but it also adjusts contract-test service configuration logic for polling which could alter how tests initialize and exercise the SDK. > > **Overview** > Adds a new `Nightly Contract Tests` GitHub Actions workflow that runs server SDK contract tests nightly (and on manual dispatch), with an optional branch override and an optional Slack test-notification path. > > Extends the `contract-tests` composite action to accept `test_harness_params` and pass them through to `make`, enabling the nightly workflow to run the harness with `-enable-long-running-tests`, and posts a Slack alert via an incoming webhook when the nightly job fails. > > Updates the contract test service to advertise `server-side-polling`, accept polling config (including a `filter`), and wire polling endpoints/data source when streaming isn’t used; also adds FDv2 suppressions for several streaming fallback/recovery tests. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 69b9f64. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: tanderson@launchdarkly.com <tanderson@launchdarkly.com> Co-authored-by: Todd Anderson <127344469+tanderson-ld@users.noreply.github.com> Co-authored-by: semgrep-code-launchdarkly[bot] <167133144+semgrep-code-launchdarkly[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds release please support