Add new method "Is" in httperror.go #2892
Open
+66
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implemented the
Ismethod on theHTTPErrorstruct, enabling error checking usingerrors.Is(particularly for comparing with sentinel errors).Background
Starting with Go 1.13,
errors.Isis recommended for error checking, but Echo'sHTTPErrordid not previously implement theIsmethod. Echo's predefined errors (such asecho.ErrNotFound) are of the internalhttpErrortype, while errors created withNewHTTPErrorare of type*HTTPError. Because these are distinct types in Go's type system,errors.Is(err, echo.ErrNotFound)would return false iferrwas of type*HTTPError, making intended error handling difficult. This change resolves the issue by adding logic that considers errors with matching status codes to be the same error.Changes
httperror.go: Added anIsmethod to theHTTPErrorstruct. When comparing against*HTTPErroror*httpError, it compares the status code.httperror_test.go: Added a test case for theIsmethod (TestHTTPError_Is).