Conversation
…are when default Echo filesytem is used (effectively `middleware.StaticConfig{Filesystem: nil}`)
…are when default Echo filesytem is used (effectively `middleware.StaticConfig{Filesystem: nil}`)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2891 +/- ##
==========================================
- Coverage 93.02% 92.92% -0.10%
==========================================
Files 43 43
Lines 4456 4480 +24
==========================================
+ Hits 4145 4163 +18
- Misses 194 197 +3
- Partials 117 120 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is a major f*ckup. We have tests for this same thing for 5+ years (from latest vuln) but in tests we created new filesystem and did not use default one. Default one can not access This was introduced in first |
|
Thanks for maintaining Echo I use it a lot and really appreciate the work. Thanks for looking into this quickly and the transparency here. |
Fix directory traversal vulnerability under Windows in Static middleware when default Echo filesystem is used. Reported by @shblue21.
This applies to cases when:
middleware.StaticConfig.Filesystemisnil(default)echo.Filesystemis has not been set explicitly (default)