attach: Move the AttachFunc default function to the initializer#67615
Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom Aug 22, 2018
Merged
Conversation
Fixes a partially constructed AttachOptions
k8s-ci-robot
added
release-note-none
Member
Author
|
/cc @sjenning |
Member
Author
|
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
/lgtm cc @soltysh for approval |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanvallejo, rphillips, sjenning, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a partially constructed AttachOptions
What this PR does / why we need it: NewAttachOptions partially constructs an AttachOptions structure. The defaultAttachFunc should be set automatically, so the caller can potentially override the default behavior.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
/cc @kubernetes/sig-cli-api-reviews