Skip to content

Set flexvolumeplugin.host so that it's not nil#51342

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
wongma7:flex-nil
Aug 28, 2017
Merged

Set flexvolumeplugin.host so that it's not nil#51342
k8s-github-robot merged 1 commit intokubernetes:masterfrom
wongma7:flex-nil

Conversation

@wongma7
Copy link
Contributor

@wongma7 wongma7 commented Aug 25, 2017 •
edited
Loading

@TerraTech @MikaelCluseau @chakri-nelluri @verult

I assume this line was removed inadvertently, without plugin.host set the flexvolume silently fails at Mount/Attach* time. #50843

#51123

Please review, thanks!

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 25, 2017
@wongma7 wongma7 mentioned this pull request Aug 25, 2017
Merged
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 25, 2017

sample failure:
#50843 (comment)

Sorry my comments are spread all over the place...

@TerraTech
Copy link

TerraTech commented Aug 25, 2017

/lgtm (good catch)

@wongma7
Copy link
Contributor Author

wongma7 commented Aug 25, 2017

/assign @TerraTech
/assign @saad-ali

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 25, 2017

@wongma7: GitHub didn't allow me to assign the following users: TerraTech.

Note that only kubernetes members can be assigned.

Details

In response to this:

/assign @TerraTech
/assign @saad-ali

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-github-robot k8s-github-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Aug 25, 2017
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 28, 2017

@saad-ali please approve this, it fixes nil pointer exception at mount/attach time for all flexvolume plugins

@wongma7
Copy link
Contributor Author

wongma7 commented Aug 28, 2017

/assign @jsafrane
/assign @gnufied

@wongma7
Copy link
Contributor Author

wongma7 commented Aug 28, 2017

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Aug 28, 2017
@jsafrane
Copy link
Member

jsafrane commented Aug 28, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Aug 28, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TerraTech, jsafrane, wongma7

Associated issue: 51123

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Aug 28, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

k8s-github-robot commented Aug 28, 2017

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 7100d00 into kubernetes:master Aug 28, 2017
@wongma7 wongma7 mentioned this pull request Sep 6, 2017
Merged
openshift-merge-robot added a commit to openshift/origin that referenced this pull request Sep 7, 2017
@openshift-merge-robot
Merge pull request #16174 from wongma7/flex
e716505 
Automatic merge from submit-queue (batch tested with PRs 15994, 16182, 16190, 16174)

UPSTREAM: 50843: FlexVolume: Add ability to control 'SupportsSELinux' during driver's init phase

also includes kubernetes/kubernetes#51342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gnufied gnufied

@jsafrane jsafrane

@derekwaynecarr derekwaynecarr

@saad-ali saad-ali

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wongma7 @TerraTech @k8s-ci-robot @jsafrane @k8s-github-robot @gnufied @derekwaynecarr @saad-ali