Skip to content

kube-vip: Fix template, drop all capabilities and use kube_vip_version#12835

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
ThisIsQasim:kube_vip_1
Jan 7, 2026
Merged

kube-vip: Fix template, drop all capabilities and use kube_vip_version#12835
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
ThisIsQasim:kube_vip_1

Conversation

@ThisIsQasim
Copy link
Copy Markdown
Contributor

@ThisIsQasim ThisIsQasim commented Jan 4, 2026 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #12839

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixed `kube_vip_version` variable for managing kube-vip version instead of `kube_vip_image_tag`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 4, 2026
@k8s-ci-robot k8s-ci-robot requested a review from tico88612 January 4, 2026 16:55
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 4, 2026

Hi @ThisIsQasim. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2026
@k8s-ci-robot k8s-ci-robot requested a review from yankay January 4, 2026 16:55
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 4, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2026
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2026
@ThisIsQasim ThisIsQasim changed the title Upgrade kube-vip to v1.0.3 Drop capabilities in kube-vip and use kube_vip_version Jan 4, 2026
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Jan 4, 2026
@ThisIsQasim
Copy link
Copy Markdown
Contributor Author

ThisIsQasim commented Jan 4, 2026

I have rebased to include some minor changes that I believe would be useful despite the upgrade being covered in #12815

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2026
@ThisIsQasim ThisIsQasim mentioned this pull request Jan 5, 2026
Closed
@ThisIsQasim ThisIsQasim changed the title Drop capabilities in kube-vip and use kube_vip_version kube-vip: Fix template, drop all capabilities and use kube_vip_version Jan 5, 2026
tico88612
tico88612 reviewed Jan 6, 2026
View reviewed changes
@tico88612
Copy link
Copy Markdown
Member

tico88612 commented Jan 6, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2026
tico88612
tico88612 approved these changes Jan 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThisIsQasim, tico88612

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2026
@k8s-ci-robot k8s-ci-robot merged commit 17c7236 into kubernetes-sigs:master Jan 7, 2026
47 checks passed
@tico88612 tico88612 mentioned this pull request Jan 7, 2026
Closed
Bafbi pushed a commit to Bafbi/kubespray that referenced this pull request Jan 12, 2026
@ThisIsQasim @Bafbi
kube-vip: Fix template, drop all capabilities and use kube_vip_version (
1205c6a 
kubernetes-sigs#12835)

* Drop capabilities in kube-vip and use kube_vip_version

* Preserve trailing newline for kube_vip_cidr env var
@ThisIsQasim ThisIsQasim mentioned this pull request Jan 26, 2026
Closed
@ThisIsQasim ThisIsQasim deleted the kube_vip_1 branch January 26, 2026 16:10
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tico88612 tico88612 tico88612 approved these changes

@yankay yankay Awaiting requested review from yankay

Assignees

@tico88612 tico88612

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kube-vip manifest generation failure due to invalid default kube_vip_cidr value

3 participants

@ThisIsQasim @k8s-ci-robot @tico88612