Fix kubelet-csr-approver deployment failes if kube_network_plugin=cni(generic)

[M-JavadHeydarpour]

What this PR does / why we need it:

This PR resolves issues with the kubelet-csr-approver deployment failing when kube_network_plugin=cni. The deployment fails because the node does not become ready until the CNI is manually installed after Kubespray playbooks have run. To address this, the PR modifies the Helm parameters as follows:

• Sets wait and atomic to false when kube_network_plugin=cni to prevent the kubelet-csr-approver job from failing during deployment.

Which issue(s) this PR fixes:

Fixes #10320
Fixes #10491

Special notes for your reviewer:

• The Helm parameters wait and atomic are conditionally set to false when using a CNI network plugin (kube_network_plugin == 'cni'), ensuring that kubelet-csr-approver does not stall if CNI is installed manually.
• This change improves the deployment process in environments where CNI installation is handled outside the Kubespray playbooks.

Does this PR introduce a user-facing change?:

Modifies Helm parameters `wait` and `atomic` to be set to `false` when using `kube_network_plugin=cni` to prevent deployment issues with `kubelet-csr-approver`.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: M-JavadHeydarpour / name: Javad (f62ca86, 80e024f)

[k8s-ci-robot]

Welcome @M-JavadHeydarpour!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @M-JavadHeydarpour. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[VannTen]

/ok-to-test {{ <bool expr> | ternary(false, true }} can be simplified to {{ not <bool expr> }}

[VannTen]

One further nitpick.

Could you also squash your fix commits into the commits they are fixing (in your PR).
(Several commits are ok, but fix commits should not be in the final PR)

[VannTen]

Suggested change

	wait: "{{ not (kube_network_plugin == 'cni') }}"
	wait: "{{ kube_network_plugin != 'cni' }}"

[M-JavadHeydarpour]

Certainly! I’ve squashed the fix commits into the main commits as requested, so the final PR is now clean and organized without separate fix commits. Let me know if there’s anything else to adjust.

[tico88612]

Hi @M-JavadHeydarpour

This is just a reminder for you: Your PR shouldn't contain any merge commits, or you will get a do-not-merge label.
Please use rebase instead of merge.

[VannTen]

/lgtm /approve Thanks !

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M-JavadHeydarpour, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [VannTen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tico88612]

/kind bug