refactor: Replace Telepresence with ko --debug#8869
refactor: Replace Telepresence with ko --debug#8869Arpit529Srivastava wants to merge 2 commits intoknative:mainfrom
Conversation
Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>
|
Welcome @Arpit529Srivastava! It looks like this is your first PR to knative/eventing 🎉 |
knative-prow
bot
added
needs-ok-to-test
|
Hi @Arpit529Srivastava. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Arpit529Srivastava The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @creydr PTAL, |
creydr
left a comment
creydr
left a comment
There was a problem hiding this comment.
Thanks a lot @Arpit529Srivastava for improving this.
I left two comments
DEVELOPMENT.md
Outdated
| ``` | ||
|
|
||
| ## Debugging Knative controllers and friends locally | ||
| ## Debugging Knative controllers and webhooks |
There was a problem hiding this comment.
| ## Debugging Knative controllers and webhooks | |
| ## Debugging Knative controllers and friends locally |
I'd keep the initial version here, because everything what is build with ko in knative can be debugged
There was a problem hiding this comment.
i see, made the changes :)
| { | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "Connect to Eventing Controller", | ||
| "type": "go", | ||
| "request": "attach", | ||
| "mode": "remote", | ||
| "port": 40000, | ||
| "host": "127.0.0.1", | ||
| "substitutePath": [ | ||
| { | ||
| "from": "${workspaceFolder}", | ||
| "to": "/go/src/knative.dev/eventing" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
@twoGiants as you're working a lot with VSCode: is all of this needed to use ko debug?
There was a problem hiding this comment.
the substitutePath is there to map the local workspace path to the go module path inside the container, so vscode can correctly resolve source locations for breakpoints. that said, i'll wait for @twoGiants's review.
Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>
addressed, thanks for the review :) |
2 participants
Fixes #7099
Proposed Changes
ko --debugapproachPre-review Checklist
Release Note
Docs
this pr updates the developer documentation (
DEVELOPMENT.md) in this repository. no external documentation changes are needed since this only affects the development workflow and not any user-facing features.