feat(eventdrop): add centralized telemetry API for dropped events#8818
feat(eventdrop): add centralized telemetry API for dropped events#8818jijo-OO7 wants to merge 1 commit intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jijo-OO7 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jijo-OO7. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WIP: Phase 1 – Centralized telemetry API for dropped events (#8572)
Description
This PR establishes the foundation for dropped event telemetry in the Broker data plane by introducing a centralized
RecordEventDroppedAPI. The package provides OpenTelemetry instrumentation (metrics and traces) for drop sites without modifying existing handler code.This is Phase 1 - API definition only. Handler integration happens in a follow-up PR once the design is validated.
Changes
pkg/eventdroppackage with:Reasonenum capturing drop causes (TTLMissing,TTLExhausted)Infostruct for drop context metadataRecordEventDropped()entry point for unified telemetryTelemetry Strategy
Following Evan's guidance in #8572:
Metrics: Low-cardinality labels only
eventing_broker_events_dropped_totalcounternamespace,broker,trigger,reasonTraces: Full context via sampling
event-droppedevent on active spansDesign Notes
Integration (Phase 1.5)
Follow-up PR will wire this into:
pkg/broker/filter/filter_handler.go(ReasonTTLMissing)pkg/broker/ingress/ingress_handler.go(ReasonTTLExhausted)Separate PR allows design review before touching handlers.
Testing
Phase 1 validates API surface and graceful degradation. Deep OTel verification deferred until Phase 1.5 integration.
cc/ @evankanderson (per #8572 guidance) @Cali0707 @matzew @creydr - Design feedback before proceeding to handler wiring would be valuable.