Documented SimpleExtensionType and simplified ExtensionSet#1
Merged
jvanstraten merged 4 commits intojvanstraten:substrait-consumerfrom Feb 11, 2022
Merged
Conversation
…s explaining the behavior and hid more of the underlying implementation which will help future-proof us in case we move to a map-based version in the future. Fixed a bug in execution plan creation where we were referencing the Substrait function name instead of the Arrow function name.
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
westonpace
commented
Feb 9, 2022
jvanstraten
requested changes
Feb 9, 2022
Owner
jvanstraten
left a comment
jvanstraten
left a comment
There was a problem hiding this comment.
Looks great; in my opinion this is much easier to understand than it was. Just a few minor things. I can also merge this in and then make the changes in my branch; let me know.
westonpace
force-pushed
the
substrait-consumer
branch
2 times, most recently
from
50ae330 to
8bd00a2
Compare
Co-authored-by: Jeroen van Straten <jeroen.van.straten@gmail.com>
Author
Either way works for me. So if you see future changes and want to just make them then go for it. |
jvanstraten
approved these changes
Feb 11, 2022
jvanstraten
pushed a commit
that referenced
this pull request
Jun 29, 2022
TODOs: Convert cheat sheet to PDF and hide slide #1. Closes apache#12445 from pachadotdev/patch-4 Lead-authored-by: Stephanie Hazlitt <stephhazlitt@gmail.com> Co-authored-by: Pachá <mvargas@dcc.uchile.cl> Co-authored-by: Mauricio Vargas <mavargas11@uc.cl> Co-authored-by: Pachá <mavargas11@uc.cl> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.