Allow skipping the testcase that requires network#63
Open
s-t-e-v-e-n-k wants to merge 1 commit intojim-easterbrook:mainfrom
Open
Allow skipping the testcase that requires network#63s-t-e-v-e-n-k wants to merge 1 commit intojim-easterbrook:mainfrom
s-t-e-v-e-n-k wants to merge 1 commit intojim-easterbrook:mainfrom
Conversation
Not all test environments allow internet access, and one of the testcases relies on it by downloading an image over HTTPS. Add a check for a environment variable to skip it.
Owner
|
Good idea. I'd really like to automate network detection instead of relying on an environment variable though. I'll investigate what's possible. |
Owner
|
Something like this should do the job: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all test environments allow internet access, and one of the testcases relies on it by downloading an image over HTTPS. Add a check for a environment variable to skip it.
If 'NONET" is not descriptive enough, I'm happy to update it to 'SKIP_NETWORK' or something else.