Merged
Conversation
Collaborator
|
@isc-hwojnick the "fixes" text should be in the description, not the title of the PR |
isc-hwojnick
changed the title
isc-tleavitt
requested changes
Jul 2, 2024
Collaborator
isc-tleavitt
left a comment
isc-tleavitt
left a comment
There was a problem hiding this comment.
Main comment: this missed the need to show and allow action on other users' changes. Discussed workflow for this with Henry, he can add his notes.
Also fixes numerous gremlins around staged/unstage Need to stage before stash, unstage before discard Diff works for staged-under-the-hood and unstaged-under-the-hood files
Collaborator
|
@isc-hwojnick @isc-pbarton I think this will be good to go, but would love to have someone other than me test it in an interoperability setting for add/modify/delete and all the edge cases you can dream of. My test case has been a production modification and add of a business rule (for a new router BP) but just as good to test in other creative ways. |
isc-pbarton
approved these changes
Jul 5, 2024
This could ultimately use some refactoring, but regardless, it's working.
isc-tleavitt
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #383, fixes #358, fixes #359, fixes #346 Workspace UI has been revamped to fall in line with the functionality that can be expected from GitHub Desktop