Merged
Conversation
Member
|
Glad to have your contribution. I don't have any windows build experience, so I'm happy for anyone else to chime in, else I'll take your word that this is working. |
Collaborator
|
I don't have any Windows machine near me anymore, but like @martindurant I would be open to merge if is working. Idea: We may set up a build service for various platforms, like Travis-CI. |
Contributor
Author
|
I don't actually have a Windows machine either, but on CIs this patch (plus msinttypes) fixes the VS9 build and doesn't break Linux / Mac / VS14 builds at conda-forge/python-snappy-feedstock#10. (Well, Mac is still waiting on Travis to build, but it'll work. 😄) |
Member
|
Good enough for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a workaround to the C headers to make it possible to compile with old versions of MSVC. Along with msinttypes, this makes it possible to build on old versions of MSVC needed for Python 2.7 on Windows. (Example of it working: conda-forge/python-snappy-feedstock#10.)
Fixes #48.