Conversation
jonarnes
reviewed
Sep 20, 2022
| import { IEFormat } from "@imageengine/imageengine-helpers"; | ||
|
|
||
| const ALLOWED_INPUT_EXTENSIONS: IEFormat[] = [ | ||
| const ALLOWED_INPUT_EXTENSIONS: (IEFormat | 'tif')[] = [ |
Contributor
There was a problem hiding this comment.
Any reason why we could't include all the file extensions like listed here in this constant?
Contributor
Author
There was a problem hiding this comment.
@jonarnes I think it is better to define a new type for allowed input file formats instead of using IEFormat because it contains type definition of allowed output formats. Since this change has to be done in helpers module I made a workaround and fix the issue and raised the pr. I will be creating a new issue to address this and update accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.