[Feature] implement a more generic vault interface#9
Merged
jake-nyquist merged 4 commits intomainfrom May 10, 2022
Merged
Conversation
Contributor
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
This was referenced May 4, 2022
regynald
approved these changes
May 4, 2022
src/HookERC721VaultImplV1.sol
Outdated
|
|
||
| /// @dev these fields mark when there is an active entitlement on this contract. If these | ||
| /// fields are non-null, the beneficial owner is unable to withdrawl until either the entitlement | ||
| /// fields are non-null, the beneficial o wner is unable to withdrawl until either the entitlement |
jake-nyquist
force-pushed
the
05-04-add_call_upgrader_role_to_the_protocol
branch
from
e1b91ed to
9031bfc
Compare
jake-nyquist
force-pushed
the
nyquist/hook-794-interface-for-vaults-that-is-not-erc-721
branch
from
78f8725 to
142e189
Compare
regynald
approved these changes
May 9, 2022
Contributor
Author
|
Graphite Merge Job Current status: ⛔ Merge stopped This pull request was previously queued to merge as part of a stack. It could not be merged because optional checks are failing. To continue, please 1) fix the tests and start a new merge or 2) manually merge past the failing tests. This comment was auto-generated by Graphite. Job Reference: vU9gfbfglkDrEURuEos3 |
jake-nyquist
changed the base branch from
05-04-add_call_upgrader_role_to_the_protocol
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we add a more generic vault interface which allows the future creation of vaults that support other, non-ERC721 asset types.
We assume here that all asset types have an address, and leave it to the vault implementation to figure out if the vault includes the relevant assets.