Verify that hook vaults are created non-maliciously (i.e. are created by the protocol)#26
Merged
jake-nyquist merged 3 commits intomainfrom May 24, 2022
Conversation
HOOK-873 Add malicious non hook authored vaults to white paper
We allow them but don't show on the front end. Indexer would only track vaults created from vault factories we explicitly track. |
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Contributor
Author
|
Make sure that we, in this pr, update the assetId in mintWithErc721. |
jake-nyquist
changed the title
regynald
approved these changes
May 24, 2022
Contributor
Author
|
Graphite Merge Job Current status: ✅ Merged This pull request was successfully merged as part of a stack. This comment was auto-generated by Graphite. Job Reference: 50vCERiddAtq8IQ4GC97 |
jake-nyquist
force-pushed
the
nyquist/hook-873-add-malicious-non-hook-authored-vaults
branch
from
bf1390f to
b6ed1aa
Compare
regynald
deleted the
nyquist/hook-873-add-malicious-non-hook-authored-vaults
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates all of the contract deploys from the proxies to utilize CREATE2. This allows us to efficiently validate elsewhere within the protocol that contracts attempting to connect are authentic. In particular; we know that vaults underlying options are authentic vaults.