[Feature] Allow for signatureless entitlements and call minting

[jake-nyquist]

No description provided.

[linear]

HOOK-837 accept entitlement as-is onErc721Received in the vault contract

In the future, we'd like to allow us or a third party to construct a 'proxy' contract which automatically bootstraps a vault and create a call option based on it. This could work in two possible ways:

A - proxy implementing onERC721Received:

 1 - find or create the vault

 2 - forwards the asset into the vault, imposing the entitlement

 3 - mints a call option based on the entitlement

B - proxy gets approved for the asset

• use gas station network or other gas forwarder to allow protocol to pay gas for the following:
  • ExecTransfer function that does (A)

Scenario B is a growth-minded approach

To make this work, we need to perform two changes to the protocol.

HookERC721VaultImplV1.sol :

• onERC721Received
  • Remove _setBeneficialOwner(from); and instead _setBeneficialOwner(entitlement.beneficialOwner);
  • Do not parse signature out of the calldata, only the packed entitlement
• _verifyAndRegisterEntitlement :
  • refactor to split the validate signature and the impose enttitlement steps (both private)
  • make validateEntitlementSignature _validateEntitlementSignature (nit: style)
  • call only the impose entitlement function (i.e. no signature validation) onERC721Received.
• Update the comments throughout (including the long one onERC721Received) to reflect the view that the holder of the asset should be trusted to set an entitlement because they could otherwise simply send the asset to an arbitrary EOA and then sign and set the entitlement from there
• Implement a grantEntitlement function that can be called at any time by the beneficial owner without a signature. This will allow smart contracts to imposeEntitlements on assets they control.

HookCoveredCallImplV1.sol :

• amend the mint with call method to accept an entitlement on a vault that is already in place so long as it matches exactly
• Perhaps, simply don't check the signature in this case to allow for an "overridden method"… i.e. if entitlement on vault aready → verify match or fail, else → impose with signature or fail.

[jake-nyquist]

Current dependencies on/for this PR:

• main
  • PR [Feature] Allow for signatureless entitlements and call minting #15 👈

This comment was auto-generated by Graphite.

[regynald]

Change require msg

[jake-nyquist]

fixed in 08ec25