This repository was archived by the owner on Sep 6, 2025. It is now read-only.
Merged
Conversation
Contributor
italolelis
commented
Mar 29, 2018
italolelis
commented
- Using contextual logging
- Using contextual github client
- New multierr pkg, for when we have multiple errors from github
- New err wrapper pkg
rafaeljesus
reviewed
Mar 29, 2018
| ctx := log.NewContext(context.Background()) | ||
| ctx, err := config.NewContext(ctx, opts.configFile) | ||
| if err != nil { | ||
| log.WithContext(ctx).WithError(err).Error("Could not load configuration file") |
There was a problem hiding this comment.
should we return err here or it's fine to continue?
Contributor
Author
There was a problem hiding this comment.
It's fine to not have the config file. You should still be able to create a repository with the defaults
rafaeljesus
approved these changes
Mar 29, 2018
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.