This repository was archived by the owner on Sep 6, 2025. It is now read-only.
PT-4024 Add option to use Zappr Github app's token for calls to Github#22
Merged
startnow65 merged 1 commit intomasterfrom Jun 28, 2019
Merged
PT-4024 Add option to use Zappr Github app's token for calls to Github#22startnow65 merged 1 commit intomasterfrom
startnow65 merged 1 commit intomasterfrom
Conversation
|
+1
|
antonu17
approved these changes
Jun 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
API Calls to Zappr can be authorized by passing a Github token. With this approach, all call made by Zappr to Github would also use this token which implies that all github checks setup as part of this process would be tied to the owner of the Github token
Before now, we got the authentication cookie used by Zappr web (UI) to authenticate to the API and used that to also authenticate to Zappr API, this approach ensured that calls made by Zappr to Github uses Zappr's Github app token as expected.
Now
An endpoint has been added to Zappr to retrieve the internal Github token that is used to call Github as Zappr.
This PR uses that endpoint to retrieve this Github token and use that for API requests to Zappr