Open
Conversation
Allow callers to choose between 'absolute' (default, existing behaviour) and 'relative' when creating an ASC log file. The value is written into the 'base hex timestamps ...' header line so that other tools (CANalyzer, CANoe, etc.) can interpret the file correctly. Closes hardbyte#2022
Collaborator
|
You're changing the header, but not the actual timestamps. According to the documentation that is not correct:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
timestamps_formatparameter toASCWriter.__init__()("absolute"or"relative", default"absolute")base hex timestamps ...header line so external tools (CANalyzer, CANoe, etc.) can interpret the file correctlyValueErrorfor unsupported values"absolute"Related Issues / Pull Requests
Type of Change
Checklist
tox).Additional Notes
The
timestamps_formatparameter only affects the header line.The actual per-message timestamp values written by
on_message_received()are not modified — callers are responsible for passing appropriately scaled timestamps.