Using GraphQLRequest instead of DocumentNode for gql, execute, subscribe methods#556
Merged
leszekhanusz merged 4 commits intographql-python:masterfrom May 28, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 38 40 +2
Lines 2908 3103 +195
==========================================
+ Hits 2908 3103 +195 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change:
gqlanddsl_gqlmethods now returns aGraphQLRequestinstead of aDocumentNodeexecuteandsubscribemethods ofClientand sessions now expects aGraphQLRequestinstead of aDocumentNodeA
GraphQLRequestis an object which contains optionalvariable_valuesandoperation_namein addition to the document.Because of that double change, the simple code examples do not need to be changed, but if you're using external methods on the result from the gql method, like
print_astwhich expects a DocumentNode, then you will need to use thedocumentattribute of the request.Before:
After:
Deprecated variable_values and operation_name in execute and subscribe methods
The new way to add
variable_valuesis to set it as a property of theGraphQLRequest, and not as an argument ofexecuteorsubscribemethods: