core: Fix duplicate VID when multiple offchain triggers fire in the same block#6336
Open
hudsonhrh wants to merge 3 commits intographprotocol:masterfrom
Open
core: Fix duplicate VID when multiple offchain triggers fire in the same block#6336hudsonhrh wants to merge 3 commits intographprotocol:masterfrom
hudsonhrh wants to merge 3 commits intographprotocol:masterfrom
Conversation
When specVersion >= 1.3.0, VIDs are computed deterministically as (block_number << 32) + vid_seq. Each offchain trigger in handle_offchain_triggers creates a fresh EntityCache with vid_seq reset to RESERVED_VIDS (100). When multiple file data source triggers fire in the same block and write to the same entity table, they produce identical VIDs, causing PostgreSQL primary key violations: "duplicate key value violates unique constraint task_metadata_pkey" Fix: Pass the onchain EntityCache's final vid_seq into handle_offchain_triggers and accumulate it across loop iterations, so each offchain trigger continues the sequence from where the previous one left off.
Two tests demonstrate the bug where multiple offchain triggers (e.g. file data sources) in the same block each create a fresh EntityCache with vid_seq reset to RESERVED_VIDS (100), producing duplicate VIDs that violate the primary key constraint. - offchain_trigger_vid_collision_without_fix: proves VIDs collide - offchain_trigger_vid_no_collision_with_fix: proves threading vid_seq across triggers prevents collisions
hudsonhrh
force-pushed
the
fix/vid-seq-offchain-collision
branch
from
20bba68 to
f24825a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each iteration of the offchain trigger loop in
handle_offchain_triggerscreates a freshBlockStatewithvid_seqreset toRESERVED_VIDS(100). When two or more offchain triggers (e.g. file/ipfs data sources) fire in the same block and write to the same entity table, they produce identical VIDs, causing a unique constraint violation.This threads
vid_seqfrom the onchainEntityCachethrough the offchain trigger loop so each trigger continues the sequence where the previous one left off. Also adds unit tests demonstrating both the collision and the fix.There are tests for illustrative purposes showing the bug and the fix
Fixes #6335