Fix postgraphile websocket/subscription omission path#31
Open
jonathanpeterwu wants to merge 3 commits intographile:mainfrom
Open
Fix postgraphile websocket/subscription omission path#31jonathanpeterwu wants to merge 3 commits intographile:mainfrom
jonathanpeterwu wants to merge 3 commits intographile:mainfrom
Conversation
Member
|
Please also update the yarn lock (assuming an upgrade is required to trigger the issue?) |
Author
|
Updated with package upgrade |
benjie
requested changes
Sep 23, 2021
Comment on lines
32
to
35
| new webpack.NormalModuleReplacementPlugin( | ||
| /postgraphile\/build\/postgraphile\/http\/subscriptions\.js$/, | ||
| /postgraphile\/build-turbo\/postgraphile\/http\/subscriptions\.js$/, | ||
| `${__dirname}/src/postgraphile-http-subscriptions.js` | ||
| ), |
Member
There was a problem hiding this comment.
I don't think this is actually a fix unless you've set GRAPHILE_TURBO which I don't think is set by default.
Instead, please throw away the yarn.lock changes and duplicate this above block - once for non-turbo and once for turbo.
Thanks!
|
@benjie is there a reason in particular we would not want to update to the most recent version of postgraphile? |
Member
|
No; just that I've tested this on older versions and I don't fancy testing it again because working with Lambda is a PITA. I'd rather go with a "known good" version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On build for the lambda example webpack bundling fails on omission of subscriptions.js as the npm install path has changed
yarn lint:fixpasses.