Skip to content

chore(python): fix formatting issue in noxfile.py.j2#1237

Merged
parthea merged 2 commits intomasterfrom
fix-formatting-issue-noxfile
Oct 7, 2021
Merged

chore(python): fix formatting issue in noxfile.py.j2#1237
parthea merged 2 commits intomasterfrom
fix-formatting-issue-noxfile

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Oct 7, 2021

This PR fixes the issue reported in googleapis/repo-automation-bots#2669, where the owlbot post processor fails due to a syntax issue.

With the existing noxfile.py.j2, the following code is generated for googleapis/python-logging

session.install("flask", "-c", constraints_path)session.install("webob", "-c", constraints_path)session.install("django", "-c", constraints_path)

Using the changes in this PR, the syntax issue appears to be fixed.

Steps to reproduce:

  1. In the root of the googleapis/synthtool repo, run docker build -t testpostprocessor -f docker/owlbot/python/Dockerfile .
  2. In the root of the googleapis/python-logging repo, run docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo testpostprocessor
  3. The above step should produce the following error owlbot-python: post-processor crashing update lock jobs repo-automation-bots#2669

To confirm this fix, repeat the above steps with the fixes in this PR.

Fixes googleapis/repo-automation-bots#2669

@parthea parthea merged commit d730883 into master Oct 7, 2021
@parthea parthea deleted the fix-formatting-issue-noxfile branch October 7, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

owlbot-python: post-processor crashing update lock jobs

2 participants