feat(bigtable): skip system tests failing with emulator#18
Merged
kolea2 merged 5 commits intogoogleapis:masterfrom May 20, 2020
Merged
feat(bigtable): skip system tests failing with emulator#18kolea2 merged 5 commits intogoogleapis:masterfrom
kolea2 merged 5 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
HemangChothani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
The 'docs' test failed which is irrelevant to the changes, issue has fixed in PR 20 |
…into bigtable_issue_5
…into bigtable_issue_5
Contributor
Author
|
System test failed is not relevant to changes, it throws error like Operation successfully rolled back : Insufficient node quota |
HemangChothani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
kolea2
reviewed
May 19, 2020
tests/system.py
Outdated
| for table in self.tables_to_delete: | ||
| table.delete() | ||
|
|
||
| def _maybe_emulator_skip(self, message): |
Collaborator
There was a problem hiding this comment.
my preference would be to name this _skip_if_emulated
kolea2
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5