feat: add support for materialized views#408
feat: add support for materialized views#408gcf-merge-on-green[bot] merged 6 commits intogoogleapis:masterfrom
Conversation
|
Here is the summary of changes. You added 6 region tags.
This comment is generated by snippet-bot.
|
shollyman
left a comment
There was a problem hiding this comment.
Minor naming ruminations, and a paste edit for the license header.
Thanks for putting this together!
google/cloud/bigquery/table.py
Outdated
There was a problem hiding this comment.
I wonder if we can use a better prefix? For logical views we're already using view_ prefix, maybe mview or matview? My worry that mv is too terse here and/or people will overlook them in favor of the logical properties.
google/cloud/bigquery/table.py
Outdated
There was a problem hiding this comment.
nit: s/view/materialized view/ since we're dealing with multiple kinds now.
There was a problem hiding this comment.
This tag makes me itchy, and expecting a DDL style ALTER MATERIALIZED VIEW statement rather than an api update call. Should we correct the tag?
There was a problem hiding this comment.
Agreed, corrected to bigquery_update_materialized_view.
The corresponding docs section has room for both. https://cloud.google.com/bigquery/docs/materialized-views#alter For example the bq table shows bq query with DDL and bq update options.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #407 🦕